Re: [PATCH net-next v2 2/3] net: dev: Makes sure netif_rx() can be invoked in any context.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-02-04 20:17:15 [-0800], Jakub Kicinski wrote:
> On Fri,  4 Feb 2022 21:12:58 +0100 Sebastian Andrzej Siewior wrote:
> > +int __netif_rx(struct sk_buff *skb)
> > +{
> > +	int ret;
> > +
> > +	trace_netif_rx_entry(skb);
> > +	ret = netif_rx_internal(skb);
> > +	trace_netif_rx_exit(ret);
> > +	return ret;
> > +}
> 
> Any reason this is not exported? I don't think there's anything wrong
> with drivers calling this function, especially SW drivers which already
> know to be in BH. I'd vote for roughly all of $(ls drivers/net/*.c) to
> get the same treatment as loopback.

Don't we end up in the same situation as netif_rx() vs netix_rx_ni()?

Sebastian



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux