On Mon, Jan 24, 2022 at 12:24 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Sun, Jan 23, 2022 at 2:19 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >
> > Removing code for ebpf program prologue generation.
> >
> > The prologue code was used to get data for extra arguments specified
> > in program section name, like:
> >
> > SEC("lock_page=__lock_page page->flags")
> > int lock_page(struct pt_regs *ctx, int err, unsigned long flags)
> > {
> > return 1;
> > }
> >
> > This code is using deprecated libbpf API and blocks its removal.
> >
> > This feature was not documented and broken for some time without
> > anyone complaining, also original authors are not responding,
> > so I'm removing it.
> >
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
> > tools/perf/Makefile.config | 11 -
> > tools/perf/builtin-record.c | 14 -
> > tools/perf/util/bpf-loader.c | 242 +---------------
> > tools/perf/util/bpf-prologue.c | 508 ---------------------------------
> > tools/perf/util/bpf-prologue.h | 37 ---
> > 5 files changed, 1 insertion(+), 811 deletions(-)
>
> Love the stats! Thanks for taking this on!
>
Hi,
Was this ever applied? If not, are there any blockers? I assume this
will go through the perf tree, right?
> > delete mode 100644 tools/perf/util/bpf-prologue.c
> > delete mode 100644 tools/perf/util/bpf-prologue.h
> >
>
> [...]
