On Thu, Jan 27, 2022 at 5:23 PM Delyan Kratunov <delyank@xxxxxx> wrote: > > Signed-off-by: Delyan Kratunov <delyank@xxxxxx> > --- You can avoid a bunch of code churn if you name the new opts variable as tattr, let's do that in this patch? CHECK_FLOW_KEYS() is probably justified, so feel free to stick to using CHECK() internally for extra formatting capabilities (we might extend ASSERT_xxx() macros eventually to support vararg format args). Also, forgot to mention in the previous patch reply, please use "selftests/bpf: " subject prefix. We are never perfectly consistent, but stats still favor selftests/bpf heavily: $ git log --oneline -- . | rg 'selftests: bpf: ' | wc -l 102 $ git log --oneline -- . | rg 'selftests/bpf: ' | wc -l 1090 > .../selftests/bpf/prog_tests/check_mtu.c | 47 +++++----- > .../selftests/bpf/prog_tests/cls_redirect.c | 30 +++--- > .../selftests/bpf/prog_tests/dummy_st_ops.c | 31 +++---- > .../selftests/bpf/prog_tests/flow_dissector.c | 75 ++++++++------- > .../selftests/bpf/prog_tests/kfree_skb.c | 16 ++-- > .../selftests/bpf/prog_tests/prog_run_xattr.c | 5 + > .../bpf/prog_tests/raw_tp_test_run.c | 85 ++++++++--------- > .../selftests/bpf/prog_tests/skb_ctx.c | 93 ++++++++----------- > .../selftests/bpf/prog_tests/skb_helpers.c | 16 ++-- > .../selftests/bpf/prog_tests/sockmap_basic.c | 19 ++-- > .../selftests/bpf/prog_tests/syscall.c | 12 +-- > .../selftests/bpf/prog_tests/test_profiler.c | 16 ++-- > .../bpf/prog_tests/xdp_adjust_tail.c | 34 +++---- > 13 files changed, 227 insertions(+), 252 deletions(-) > [...]
