On Thu, Jan 27, 2022 at 8:37 AM Yonghong Song <yhs@xxxxxx> wrote:
>
> When building selftests/bpf with clang
> make -j LLVM=1
> make -C tools/testing/selftests/bpf -j LLVM=1
> I hit the following compilation error:
>
> trace_helpers.c:152:9: error: variable 'found' is used uninitialized whenever 'while' loop exits because its condition is false [-Werror,-Wsometimes-uninitialized]
> while (fscanf(f, "%zx-%zx %s %zx %*[^\n]\n", &start, &end, buf, &base) == 4) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> trace_helpers.c:161:7: note: uninitialized use occurs here
> if (!found)
> ^~~~~
> trace_helpers.c:152:9: note: remove the condition if it is always true
> while (fscanf(f, "%zx-%zx %s %zx %*[^\n]\n", &start, &end, buf, &base) == 4) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1
> trace_helpers.c:145:12: note: initialize the variable 'found' to silence this warning
> bool found;
> ^
> = false
>
> It is possible that for sane /proc/self/maps we may never hit the above issue
> in practice. But let us initialize variable 'found' properly to silence the
> compilation error.
>
> Signed-off-by: Yonghong Song <yhs@xxxxxx>
Applied. Thanks
