Re: [PATCH bpf-next] bpf: remove unused static inlines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 26 Jan 2022 21:22:03 -0800 Alexei Starovoitov wrote:
> On Wed, Jan 26, 2022 at 9:15 PM John Fastabend <john.fastabend@xxxxxxxxx> wrote:
> >
> > Jakub Kicinski wrote:  
> > > Remove two dead stubs, sk_msg_clear_meta() was never
> > > used, use of xskq_cons_is_full() got replaced by
> > > xsk_tx_writeable() in v5.10.
> > >
> > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> > > ---  
> >
> > Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>  
> 
> Applied.
> How did you find them?

regex and some bash:

for f in $(sed -n '/static inline [^(]*$/N;s@static inline.*[^_a-z0-9A-Z]\([_a-z0-9A-Z]*\)([a-z_].*@\1@p' $(find include/ -type f) ); do cnt=$(git grep $f | wc -l); [ $cnt -le 1 ] && echo $f >> single; done

takes too long to run to put it in a CI directly, unfortunately, 
more intelligence would be needed. Luckily there isn't that many
instances throughout netdev and bpf so perhaps not even worth 
the hassle.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux