Hi Masami, I love your patch! Yet something to improve: [auto build test ERROR on rostedt-trace/for-next] [also build test ERROR on arm64/for-next/core tip/x86/core linus/master v5.17-rc1 next-20220124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/fprobe-Introduce-fprobe-function-entry-exit-probe/20220125-001253 base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next config: arm-aspeed_g5_defconfig (https://download.01.org/0day-ci/archive/20220125/202201250328.drn6ia3n-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/df6df88bb474db78d80fc5619d39b25ec15d5d16 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Masami-Hiramatsu/fprobe-Introduce-fprobe-function-entry-exit-probe/20220125-001253 git checkout df6df88bb474db78d80fc5619d39b25ec15d5d16 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/kernel/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): arch/arm/kernel/stacktrace.c: In function 'unwind_frame': >> arch/arm/kernel/stacktrace.c:71:56: error: 'struct stackframe' has no member named 'tsk' 71 | frame->pc = rethook_find_ret_addr(frame->tsk, frame->fp, | ^~ >> arch/arm/kernel/stacktrace.c:72:57: error: 'struct stackframe' has no member named 'kr_cur' 72 | &frame->kr_cur); | ^~ vim +71 arch/arm/kernel/stacktrace.c 12 13 #if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) 14 /* 15 * Unwind the current stack frame and store the new register values in the 16 * structure passed as argument. Unwinding is equivalent to a function return, 17 * hence the new PC value rather than LR should be used for backtrace. 18 * 19 * With framepointer enabled, a simple function prologue looks like this: 20 * mov ip, sp 21 * stmdb sp!, {fp, ip, lr, pc} 22 * sub fp, ip, #4 23 * 24 * A simple function epilogue looks like this: 25 * ldm sp, {fp, sp, pc} 26 * 27 * When compiled with clang, pc and sp are not pushed. A simple function 28 * prologue looks like this when built with clang: 29 * 30 * stmdb {..., fp, lr} 31 * add fp, sp, #x 32 * sub sp, sp, #y 33 * 34 * A simple function epilogue looks like this when built with clang: 35 * 36 * sub sp, fp, #x 37 * ldm {..., fp, pc} 38 * 39 * 40 * Note that with framepointer enabled, even the leaf functions have the same 41 * prologue and epilogue, therefore we can ignore the LR value in this case. 42 */ 43 int notrace unwind_frame(struct stackframe *frame) 44 { 45 unsigned long high, low; 46 unsigned long fp = frame->fp; 47 48 /* only go to a higher address on the stack */ 49 low = frame->sp; 50 high = ALIGN(low, THREAD_SIZE); 51 52 #ifdef CONFIG_CC_IS_CLANG 53 /* check current frame pointer is within bounds */ 54 if (fp < low + 4 || fp > high - 4) 55 return -EINVAL; 56 57 frame->sp = frame->fp; 58 frame->fp = *(unsigned long *)(fp); 59 frame->pc = *(unsigned long *)(fp + 4); 60 #else 61 /* check current frame pointer is within bounds */ 62 if (fp < low + 12 || fp > high - 4) 63 return -EINVAL; 64 65 /* restore the registers from the stack frame */ 66 frame->fp = *(unsigned long *)(fp - 12); 67 frame->sp = *(unsigned long *)(fp - 8); 68 frame->pc = *(unsigned long *)(fp - 4); 69 #endif 70 if (IS_ENABLED(CONFIG_RETHOOK) && is_rethook_trampoline(frame->pc)) > 71 frame->pc = rethook_find_ret_addr(frame->tsk, frame->fp, > 72 &frame->kr_cur); 73 #ifdef CONFIG_KRETPROBES 74 if (is_kretprobe_trampoline(frame->pc)) 75 frame->pc = kretprobe_find_ret_addr(frame->tsk, 76 (void *)frame->fp, &frame->kr_cur); 77 #endif 78 79 return 0; 80 } 81 #endif 82 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
