Re: [RFC PATCH v3 net-next 0/4] Preserve mono delivery time (EDT) in skb->tstamp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 22, 2022 at 10:43:57AM -0500, Willem de Bruijn wrote:
> This overall looks great to me.
> 
> The only effect on timestamping is slightly delayed receive timestamp
> for packets arriving over a virtual loop (loopback, veth, ..)
> interface, as the timestamp is now captured at the network protocol
> input.
> 
> Actually, while writing that: timestamping is a socket level option,
> not specific to IP. Might this break receive timestamping over such
> interfaces for other protocols?
The EDT (and the skb->mono_delivery_time bit) is only set for TCP
which is IP only.  For other non IP skb->protocol, that bit is
not set, so the skb->tstamp should have been cleared as before.

Thanks for the review !



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux