On Wed, Jan 12, 2022 at 1:08 PM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > > 2022-01-12 09:27 UTC-0500 ~ Mauricio Vásquez <mauricio@xxxxxxxxxx> > > This commit extends libbpf with the features that are needed to > > implement BTFGen: > > > > - Implement bpf_core_create_cand_cache() and bpf_core_free_cand_cache() > > to handle candidates cache. > > - Expose bpf_core_add_cands() and bpf_core_free_cands to handle > > candidates list. > > - Expose bpf_core_calc_relo_insn() to bpftool. > > > > Signed-off-by: Mauricio Vásquez <mauricio@xxxxxxxxxx> > > Signed-off-by: Rafael David Tinoco <rafael.tinoco@xxxxxxxxxxx> > > Signed-off-by: Lorenzo Fontana <lorenzo.fontana@xxxxxxxxxx> > > Signed-off-by: Leonardo Di Donato <leonardo.didonato@xxxxxxxxxx> > > --- > > tools/lib/bpf/Makefile | 2 +- > > tools/lib/bpf/libbpf.c | 43 +++++++++++++++++++++------------ > > tools/lib/bpf/libbpf_internal.h | 12 +++++++++ > > 3 files changed, 41 insertions(+), 16 deletions(-) > > > > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > > index f947b61b2107..dba019ee2832 100644 > > --- a/tools/lib/bpf/Makefile > > +++ b/tools/lib/bpf/Makefile > > @@ -239,7 +239,7 @@ install_lib: all_cmd > > > > SRC_HDRS := bpf.h libbpf.h btf.h libbpf_common.h libbpf_legacy.h xsk.h \ > > bpf_helpers.h bpf_tracing.h bpf_endian.h bpf_core_read.h \ > > - skel_internal.h libbpf_version.h > > + skel_internal.h libbpf_version.h relo_core.h libbpf_internal.h > > GEN_HDRS := $(BPF_GENERATED) > > I don't think these headers should be added to libbpf's SRC_HDRS. If we > must make them available to bpftool, we probably want to copy them > explicitly through LIBBPF_INTERNAL_HDRS in bpftool's Makefile. I got confused, thanks for catching this up!
