Hi Ian, On 17/01/2022 16:28, Ian Rogers wrote: > [...] > Thanks for fixing this, I can add an acked-by for the v2 patch. Could > we add a test for this to avoid future regressions? There are similar > tests for frequency like: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/attr/test-record-freq > based on the attr.py test: > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/attr.py > The test specifies a base type of event attribute and then what is > modified by the test. It takes a little to get your head around but > having a test for this would be a welcome addition. I agree I should have included a test for this fix. I'll look into this for the v2. Other events such as "-p 10000 -e cycles//" worked fine. Only the ones with aux area tracing (arm_spe, cs_etm, intel_pt) were ignoring the global config flags. Thank you for the pointers, and the review, German > > Thanks! > Ian > >> Thanks for the review, >> German
