Hi Alexei, > Pretty cool that a single 'if' is all that is needed to enable > sleepable iterators. > > Maybe combine under one 'if' ? > if (prog->aux->sleepable) { > lock_trace > migr_dis > might_fault > bpf_prog_run > migr_en > unlock_trace > } else { > lock > migr_dis > bpf_prog_run > migr_end > unlock > } > > Would it be easier to read? Yes, I agree, that is more readable. I'll make the change. I'll also follow Yonghong Song's suggestion (offline) of merging this patch into the first patch to keep bisectability together. Thanks for the feedback! Kenny