On Fri, Jan 14, 2022 at 8:50 AM Jesper Dangaard Brouer
<jbrouer@xxxxxxxxxx> wrote:
>
>
>
> On 14/01/2022 03.09, Alexei Starovoitov wrote:
> > On Thu, Jan 13, 2022 at 3:58 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote:
> >>>
> >>> Btw "xdp_cpumap" should be cleaned up.
> >>> xdp_cpumap is an attach type. It's not prog type.
> >>> Probably it should be "xdp/cpumap" to align with "cgroup/bind[46]" ?
> >>
> >> so for xdp "mb" or xdp "frags" it will be xdp/cpumap.mb (xdp/devmap.mb) or
> >> xdp/cpumap.frags (xdp/devmap.frags), right?
> >
> > xdp.frags/cpumap
> > xdp.frags/devmap
> >
> > The current de-facto standard for SEC("") in libbpf:
> > prog_type.prog_flags/attach_place
>
> Ups, did we make a mistake with SEC("xdp_devmap/")
>
> and can we correct without breaking existing programs?
>
We can (at the very least) add the correct sections, even if we leave the
current incorrect ones as well. Ideally we'd mark the incorrect ones deprecated
and either remove them before libbpf 1.0 or as part of 2.0?
--Zvi
> > "attach_place" is either function_name for fentry/, tp/, lsm/, etc.
> > or attach_type/hook/target for cgroup/bind4, cgroup_skb/egress.
> >
> > lsm.s/socket_bind -> prog_type = LSM, flags = SLEEPABLE
> > lsm/socket_bind -> prog_type = LSM, non sleepable.
> >
>
