> On Jan 13, 2022, at 4:07 PM, davidcomponentone@xxxxxxxxx wrote: > > From: Yang Guang <yang.guang5@xxxxxxxxxx> > > The coccinelle report > ./tools/lib/bpf/libbpf.c:1653:43-48: > WARNING: conversion to bool not needed here > > Relational and logical operators evaluate to bool, > explicit conversion is overly verbose and unneeded. > > Reported-by: Zeal Robot <zealci@xxxxxxxxxx> > Signed-off-by: Yang Guang <yang.guang5@xxxxxxxxxx> > Signed-off-by: David Yang <davidcomponentone@xxxxxxxxx> I think this change has been NACK'ed multiple times. I guess it is a good idea NOT to send it again. Thanks, Song > --- > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 7f10dd501a52..f87787608795 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -1650,7 +1650,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val, > ext->name, value); > return -EINVAL; > } > - *(bool *)ext_val = value == 'y' ? true : false; > + *(bool *)ext_val = value == 'y'; > break; > case KCFG_TRISTATE: > if (value == 'y') > -- > 2.30.2 >
