2022-01-07 10:26 UTC-0500 ~ Mauricio Vásquez <mauricio@xxxxxxxxxx> > hashmap__new() encodes errors with ERR_PTR(), hence it's not valid to > check the returned pointer against NULL and IS_ERR() has to be used > instead. > > libbpf_get_error() can't be used in this case as hashmap__new() is not > part of the public libbpf API and it'll continue using ERR_PTR() after > libbpf 1.0. > > Fixes: 8f184732b60b ("bpftool: Switch to libbpf's hashmap for pinned paths of BPF objects") > Fixes: 2828d0d75b73 ("bpftool: Switch to libbpf's hashmap for programs/maps in BTF listing") > Fixes: d6699f8e0f83 ("bpftool: Switch to libbpf's hashmap for PIDs/names references") > > Signed-off-by: Mauricio Vásquez <mauricio@xxxxxxxxxx> This looks good to me, thank you for the fix! Reviewed-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>