On Wed, 2021-12-22 at 13:39 -0800, Andrii Nakryiko wrote: > Refactor PT_REGS macros definitions in bpf_tracing.h to avoid > excessive > duplication. We currently have classic PT_REGS_xxx() and CO-RE- > enabled > PT_REGS_xxx_CORE(). We are about to add also _SYSCALL variants, which > would require excessive copying of all the per-architecture > definitions. > > Instead, separate architecture-specific field/register names from the > final macro that utilize them. That way for upcoming _SYSCALL > variants > we'll be able to just define x86_64 exception and otherwise have one > common set of _SYSCALL macro definitions common for all > architectures. > > Cc: Kenta Tada <Kenta.Tada@xxxxxxxx> > Cc: Hengqi Chen <hengqi.chen@xxxxxxxxx> > Cc: Björn Töpel <bjorn@xxxxxxxxxx> > Cc: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > --- > tools/lib/bpf/bpf_tracing.h | 377 +++++++++++++++------------------- > -- > 1 file changed, 152 insertions(+), 225 deletions(-) Works fine on s390, and looks good to me. For both patches: Tested-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> Acked-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> Best regards, Ilya
