> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Maciej Fijalkowski > Sent: Monday, December 13, 2021 9:01 PM > To: intel-wired-lan@xxxxxxxxxxxxxxxx > Cc: Mathew, Elza <elza.mathew@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; > kuba@xxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; Karlsson, > Magnus <magnus.karlsson@xxxxxxxxx> > Subject: [Intel-wired-lan] [PATCH v2 intel-net 1/6] ice: xsk: return xsk buffers > back to pool when cleaning the ring > > Currently we only NULL the xdp_buff pointer in the internal SW ring but we > never give it back to the xsk buffer pool. This means that buffers can be > leaked out of the buff pool and never be used again. > > Add missing xsk_buff_free() call to the routine that is supposed to clean the > entries that are left in the ring so that these buffers in the umem can be used > by other sockets. > > Also, only go through the space that is actually left to be cleaned instead of a > whole ring. > > Fixes: 2d4238f55697 ("ice: Add support for AF_XDP") > Signed-off-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> > --- > drivers/net/ethernet/intel/ice/ice_xsk.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Tested-by: Kiran Bhandare <kiranx.bhandare@xxxxxxxxx> A Contingent Worker at Intel