Hi Jakub, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/bpf-remove-the-cgroup-bpf-header-dependecy/20211214-074344 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: s390-randconfig-r023-20211213 (https://download.01.org/0day-ci/archive/20211215/202112150326.PHRPQfmk-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/517f95dd6d9264e4104cfc35eecdd5c1287738ae git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jakub-Kicinski/bpf-remove-the-cgroup-bpf-header-dependecy/20211214-074344 git checkout 517f95dd6d9264e4104cfc35eecdd5c1287738ae # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): arch/s390/mm/hugetlbpage.c: In function 'hugetlb_get_unmapped_area': >> arch/s390/mm/hugetlbpage.c:352:16: error: implicit declaration of function 'check_asce_limit'; did you mean 'check_data_rlimit'? [-Werror=implicit-function-declaration] 352 | return check_asce_limit(mm, addr, len); | ^~~~~~~~~~~~~~~~ | check_data_rlimit cc1: some warnings being treated as errors vim +352 arch/s390/mm/hugetlbpage.c 5f490a520bcb393 Gerald Schaefer 2020-01-16 315 5f490a520bcb393 Gerald Schaefer 2020-01-16 316 unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, 5f490a520bcb393 Gerald Schaefer 2020-01-16 317 unsigned long len, unsigned long pgoff, unsigned long flags) 5f490a520bcb393 Gerald Schaefer 2020-01-16 318 { 5f490a520bcb393 Gerald Schaefer 2020-01-16 319 struct hstate *h = hstate_file(file); 5f490a520bcb393 Gerald Schaefer 2020-01-16 320 struct mm_struct *mm = current->mm; 5f490a520bcb393 Gerald Schaefer 2020-01-16 321 struct vm_area_struct *vma; 5f490a520bcb393 Gerald Schaefer 2020-01-16 322 5f490a520bcb393 Gerald Schaefer 2020-01-16 323 if (len & ~huge_page_mask(h)) 5f490a520bcb393 Gerald Schaefer 2020-01-16 324 return -EINVAL; 5f490a520bcb393 Gerald Schaefer 2020-01-16 325 if (len > TASK_SIZE - mmap_min_addr) 5f490a520bcb393 Gerald Schaefer 2020-01-16 326 return -ENOMEM; 5f490a520bcb393 Gerald Schaefer 2020-01-16 327 5f490a520bcb393 Gerald Schaefer 2020-01-16 328 if (flags & MAP_FIXED) { 5f490a520bcb393 Gerald Schaefer 2020-01-16 329 if (prepare_hugepage_range(file, addr, len)) 5f490a520bcb393 Gerald Schaefer 2020-01-16 330 return -EINVAL; 5f490a520bcb393 Gerald Schaefer 2020-01-16 331 goto check_asce_limit; 5f490a520bcb393 Gerald Schaefer 2020-01-16 332 } 5f490a520bcb393 Gerald Schaefer 2020-01-16 333 5f490a520bcb393 Gerald Schaefer 2020-01-16 334 if (addr) { 5f490a520bcb393 Gerald Schaefer 2020-01-16 335 addr = ALIGN(addr, huge_page_size(h)); 5f490a520bcb393 Gerald Schaefer 2020-01-16 336 vma = find_vma(mm, addr); 5f490a520bcb393 Gerald Schaefer 2020-01-16 337 if (TASK_SIZE - len >= addr && addr >= mmap_min_addr && 5f490a520bcb393 Gerald Schaefer 2020-01-16 338 (!vma || addr + len <= vm_start_gap(vma))) 5f490a520bcb393 Gerald Schaefer 2020-01-16 339 goto check_asce_limit; 5f490a520bcb393 Gerald Schaefer 2020-01-16 340 } 5f490a520bcb393 Gerald Schaefer 2020-01-16 341 5f490a520bcb393 Gerald Schaefer 2020-01-16 342 if (mm->get_unmapped_area == arch_get_unmapped_area) 5f490a520bcb393 Gerald Schaefer 2020-01-16 343 addr = hugetlb_get_unmapped_area_bottomup(file, addr, len, 5f490a520bcb393 Gerald Schaefer 2020-01-16 344 pgoff, flags); 5f490a520bcb393 Gerald Schaefer 2020-01-16 345 else 5f490a520bcb393 Gerald Schaefer 2020-01-16 346 addr = hugetlb_get_unmapped_area_topdown(file, addr, len, 5f490a520bcb393 Gerald Schaefer 2020-01-16 347 pgoff, flags); 712fa5f294f377e Alexander Gordeev 2020-03-23 348 if (offset_in_page(addr)) 5f490a520bcb393 Gerald Schaefer 2020-01-16 349 return addr; 5f490a520bcb393 Gerald Schaefer 2020-01-16 350 5f490a520bcb393 Gerald Schaefer 2020-01-16 351 check_asce_limit: 712fa5f294f377e Alexander Gordeev 2020-03-23 @352 return check_asce_limit(mm, addr, len); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
