On Tue, Nov 30, 2021 at 11:19 PM Hou Tao <houtao1@xxxxxxxxxx> wrote: > > An extra newline will output for bpf_log() with BPF_LOG_KERNEL level > as shown below: > > [ 52.095704] BPF:The function test_3 has 12 arguments. Too many. > [ 52.095704] > [ 52.096896] Error in parsing func ptr test_3 in struct bpf_dummy_ops > > Now all bpf_log() are ended by newline, but not all btf_verifier_log() > are ended by newline, so checking whether or not the log message > has the trailing newline and adding a newline if not. > > Also there is no need to calculate the left userspace buffer size > for kernel log output and to truncate the output by '\0' which > has already been done by vscnprintf(), so only do these for > userspace log output. > > Signed-off-by: Hou Tao <houtao1@xxxxxxxxxx> > Acked-by: Yonghong Song <yhs@xxxxxx> > Acked-by: Martin KaFai Lau <kafai@xxxxxx> Applied this patch. Thanks
