cgroup_storage_type() is a static inline which needs to deference bpf_map. Move it to its own header so that we don't need to pull in bpf.h. It only has a couple of callers. Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> --- include/linux/bpf-cgroup-storage.h | 17 +++++++++++++++++ include/linux/bpf-cgroup.h | 9 --------- kernel/bpf/helpers.c | 1 + kernel/bpf/local_storage.c | 1 + 4 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 include/linux/bpf-cgroup-storage.h diff --git a/include/linux/bpf-cgroup-storage.h b/include/linux/bpf-cgroup-storage.h new file mode 100644 index 000000000000..0e0f3409c586 --- /dev/null +++ b/include/linux/bpf-cgroup-storage.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _BPF_CGROUP_STORAGE_H +#define _BPF_CGROUP_STORAGE_H + +#include <linux/bpf.h> +#include <linux/bpf-cgroup.h> + +static inline enum bpf_cgroup_storage_type cgroup_storage_type( + struct bpf_map *map) +{ + if (map->map_type == BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) + return BPF_CGROUP_STORAGE_PERCPU; + + return BPF_CGROUP_STORAGE_SHARED; +} + +#endif diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h index 11820a430d6c..12474516e0be 100644 --- a/include/linux/bpf-cgroup.h +++ b/include/linux/bpf-cgroup.h @@ -194,15 +194,6 @@ int __cgroup_bpf_run_filter_getsockopt_kern(struct sock *sk, int level, int optname, void *optval, int *optlen, int retval); -static inline enum bpf_cgroup_storage_type cgroup_storage_type( - struct bpf_map *map) -{ - if (map->map_type == BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE) - return BPF_CGROUP_STORAGE_PERCPU; - - return BPF_CGROUP_STORAGE_SHARED; -} - struct bpf_cgroup_storage * cgroup_storage_lookup(struct bpf_cgroup_storage_map *map, void *key, bool locked); diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 1ffd469c217f..352acea8e53a 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -2,6 +2,7 @@ /* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com */ #include <linux/bpf.h> +#include <linux/bpf-cgroup-storage.h> #include <linux/rcupdate.h> #include <linux/random.h> #include <linux/smp.h> diff --git a/kernel/bpf/local_storage.c b/kernel/bpf/local_storage.c index 035e9e3a7132..195f9c13ef5b 100644 --- a/kernel/bpf/local_storage.c +++ b/kernel/bpf/local_storage.c @@ -1,5 +1,6 @@ //SPDX-License-Identifier: GPL-2.0 #include <linux/bpf-cgroup.h> +#include <linux/bpf-cgroup-storage.h> #include <linux/bpf.h> #include <linux/bpf_local_storage.h> #include <linux/btf.h> -- 2.31.1