Re: [PATCH v2 bpf-next 12/12] selftests/bpf: Additional test for CO-RE in the kernel.

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Tue, Nov 16, 2021 at 08:18:44PM -0800, Andrii Nakryiko wrote:
> > +
> > +       skel = core_kern_lskel__open_and_load();
> > +       if (!ASSERT_OK_PTR(skel, "open_and_load"))
> > +               goto cleanup;
> > +
> > +       err = core_kern_lskel__attach(skel);
> 
> Why attaching if you are never triggering it? This test is about
> testing load, right? Let's drop the attach then.

Good point. Indeed!