Re: [PATCH v18 bpf-next 20/23] net: xdp: introduce bpf_xdp_pointer utility routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Nov 2021 01:12:41 +0100 Lorenzo Bianconi wrote:
> ack, you are right. Sorry for the issue.
> I did not trigger the problem with xdp-mb self-tests since we will not run
> bpf_xdp_copy_buf() in this specific case, but just the memcpy()
> (but what you reported is a bug and must be fixed). I will add more
> self-tests.
> Moreover, reviewing the code I guess we can just update bpf_xdp_copy() for our case.
> Something like:

Seems reasonable.  We could probably play some tricks with double
pointers to avoid the ternary operator being re-evaluated for each
chunk. But even if it's faster it is probably not worth the ugliness
of the code.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux