On Mon, 15 Nov 2021 23:33:06 +0100 Lorenzo Bianconi wrote: > + if (!rxq->frag_size || rxq->frag_size > xdp->frame_sz) Why the latter check? > + return -EOPNOTSUPP; > + > + tailroom = rxq->frag_size - skb_frag_size(frag) - skb_frag_off(frag); Looks good. We can adjust/extend the exact semantics as drivers add support. Important part is we should be safe from negligence. Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>