Re: [PATCH v18 bpf-next 12/23] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 15 Nov 2021 23:33:06 +0100 Lorenzo Bianconi wrote:
> +	if (!rxq->frag_size || rxq->frag_size > xdp->frame_sz)

Why the latter check?

> +		return -EOPNOTSUPP;
> +
> +	tailroom = rxq->frag_size - skb_frag_size(frag) - skb_frag_off(frag);

Looks good. We can adjust/extend the exact semantics as drivers add
support. Important part is we should be safe from negligence.

Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux