Re: [RFC PATCH 1/2] bpf: do not WARN in bpf_warn_invalid_xdp_action()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paolo Abeni <pabeni@xxxxxxxxxx> writes:

> The WARN_ONCE() in bpf_warn_invalid_xdp_action() can be triggered by
> any bugged program, and even attaching a correct program to a NIC
> not supporting the given action.
>
> The resulting splat, beyond polluting the logs, fouls automated tools:
> e.g. a syzkaller reproducers using an XDP program returning an
> unsupported action will never pass validation.
>
> Replace the WARN_ONCE with a less intrusive pr_warn_once().
>
> Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>

Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux