Thu, Nov 04, 2021 at 02:32:37PM +0800, Hou Tao wrote: > In fentry__x64_sys_write(), you just do trigger updates to maps, so for the > portability of the test > (e.g. run-able for arm64) Agreed that the test should be runnable on arm64. I haven't tested there yet but I'll do that before sending out v4. > and minimal dependency (e.g. don't depends on /tmp), > why do you > using nanosleep() and replacing fentry_x64_sys_write by > tp/syscalls/sys_enter_nanosleep instead. As written, the example actually modifies the return of write(), so I don't think I can switch to tp/syscalls/* without significantly reworking the example. To minimize the amount of reworking while improving compatibility, how does this sound: 1. Add #ifdefs to support arm64 2. Instead of opening /tmp/map_trace_test_file, open /dev/null Of course this isn't as portable as your proposal but I think it might be an acceptable compromise. Best, Joe
