On Sat, Nov 6, 2021 at 12:56 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Sat, Nov 6, 2021 at 9:38 AM Alexei Starovoitov > <alexei.starovoitov@xxxxxxxxx> wrote: > > > > On Fri, Nov 5, 2021 at 12:11 PM Andrii Nakryiko <andrii@xxxxxxxxxx> wrote: > > > > > > Fix the `int i` declaration inside the for statement. This is non-C89 > > > compliant. See [0] for user report breaking BCC build. > > > > > > [0] https://github.com/libbpf/libbpf/issues/403 > > > > I'd prefer to fix bcc and/or its derivatives instead. > > It's year 2021. > > Fixing BCC and derivatives is a separate topic. This is the only > instance of non-C89 compliant for() loop in libbpf and I'd prefer to > fix it at the very least for style consistency. Fair enough. Applied.
