On 11/4/21 7:37 AM, Nghia Le wrote: > The newinet value is initialized with inet_sk() in a block code to > handle sockets for the ETH_P_IP protocol. Along this code path, > newinet is never read. Thus, assignment to newinet is needless and > can be removed. > > Signed-off-by: Nghia Le <nghialm78@xxxxxxxxx> > --- > net/ipv6/tcp_ipv6.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c > index 2cc9b0e53ad1..551fce49841d 100644 > --- a/net/ipv6/tcp_ipv6.c > +++ b/net/ipv6/tcp_ipv6.c > @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff * > > inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk); > > - newinet = inet_sk(newsk); > newnp = tcp_inet6_sk(newsk); > newtp = tcp_sk(newsk); > > Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
