> On Tue, Nov 2, 2021 at 5:14 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote: > > > > > > 1. it's tweaking __cpu_map_load_bpf_program() > > > to pass extra 'map' argument further into this helper, > > > but the 'map' is unused. > > > > For xdp multi-buff we will need to extend Toke's bpf_prog_map_compatible fix > > running bpf_prog_map_compatible routine for cpumaps and devmaps in > > order to avoid mixing xdp mb and xdp legacy programs in a cpumaps or devmaps. > > For this reason I guess we will need to pass map pointer to > > __cpu_map_load_bpf_program anyway. > > I do not have a strong opinion on it, but the main idea here is just to have a > > common code and avoid adding the same changes to cpumap and devmap. > > Anyway if you prefer to do it separately for cpumap and devmap I am fine > > with it. > > None of that information was in the original commit log. > Please make sure to provide such details in the future and make it > part of the series. > That patch alone is unnecessary. Yes, right. Sorry for the noise. Regarding this patch, do you want me to repost with a proper commit log (maybe included in the xdp multi-buff series) or do you prefer to just drop it? Regards, Lorenzo
Attachment:
signature.asc
Description: PGP signature
