On Tue, Nov 2, 2021 at 1:11 PM Yonghong Song <yhs@xxxxxx> wrote: > > > > -static int sock_map_prog_update(struct bpf_map *map, struct bpf_prog *prog, > > - struct bpf_prog *old, u32 which) > > +static int sock_map_prog_lookup(struct bpf_map *map, struct bpf_prog **pprog[], > > Can we just change "**pprog[]" to "***pprog"? In the code, you really > just pass the address of the decl "struct bpf_prog **pprog;" to the > function. Di, this feedback was given twice already. You also didn't address several other points from the earlier reviews. Please do not resubmit until you address all points.