On Fri, Oct 29, 2021 at 09:59:29PM -0700, Andrii Nakryiko wrote:
> Move internal sys_bpf() helper into bpf.h and expose as public API.
> __NR_bpf definition logic is also moved. Renamed sys_bpf() into bpf() to
> follow libbpf naming conventions. Adapt internal uses accordingly.
...
> -static inline int sys_bpf(enum bpf_cmd cmd, union bpf_attr *attr,
> - unsigned int size)
> -{
> - return syscall(__NR_bpf, cmd, attr, size);
> -}
> -
...
> +static inline long bpf(enum bpf_cmd cmd, union bpf_attr *attr, unsigned int size)
> +{
> + return syscall(__NR_bpf, cmd, attr, size);
> +}
I think it will conflict with glibc.
It will also conflict with systemd that uses bpf() from glibc or does:
#if !HAVE_BPF
static inline int missing_bpf(int cmd, union bpf_attr *attr, size_t size) {
#ifdef __NR_bpf
return (int) syscall(__NR_bpf, cmd, attr, size);
#else
errno = ENOSYS;
return -1;
#endif
}
# define bpf missing_bpf
why take a risk of renaming?
