On Wed, 27 Oct 2021 at 19:21, Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > > > > I could reduce this to just the three different variants, it opens us > > up to another map_get_fd_by_id. > > yes, but even with all of them there is still a risk of repeating > map_get_fd_by_id mistake. > To make progress maybe let's land the bits that we agree on > and keep brainstorming on the rest? Sounds good to me, which parts are good to go from your side? I wanted to join BPF office hours yesterday to discuss, but I got sidetracked. I'll join next week instead. > Or that's too little to be useful for automatic golang conversion? > If the whole thing is needed then golang converting script > should probably be part of the series otherwise things will bit rot. Every little helps I would say. Good point on bit rot, does it make sense to e.g. not allow new defines by default, etc.? We could hook it into the Makefile of selftests/bpf or some such? Lorenz -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com
