Oh I completely missed the first email. Sorry about that! Thanks for the patch Xu. On Thu, Oct 21, 2021 at 3:05 PM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Mon, Oct 18, 2021 at 8:24 PM Xu Kuohai <xukuohai@xxxxxxxxxx> wrote: > > > > 1. The ufd in generic_map_update_batch() should be read from batch.map_fd; > > 2. A call to fdget() should be followed by a symmetric call to fdput(). > > > > Fixes: aa2e93b8e58e ("bpf: Add generic support for update and delete batch ops") > > Signed-off-by: Xu Kuohai <xukuohai@xxxxxxxxxx> > > Ouch. Thanks for the fix. Applied. > > Brian, > when your bugs are fixed please pay attention in the future and > review the fix with Reviewed-by or Acked-by.