Re: [PATCH bpf-next 2/2] tools: Switch to new btf__type_cnt/btf__raw_data APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2021/10/20 1:50 AM, Andrii Nakryiko wrote:
> On Sat, Oct 9, 2021 at 8:01 AM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote:
>>
>> Replace the calls to btf__get_nr_types/btf__get_raw_data in tools
>> with new APIs btf__type_cnt/btf__raw_data. The old APIs will be
>> deprecated in recent release of libbpf.
> 
> "in libbpf v0.7+"
> 
>>
>> Signed-off-by: Hengqi Chen <hengqi.chen@xxxxxxxxx>
>> ---
>>  tools/bpf/bpftool/btf.c                              | 12 ++++++------
>>  tools/bpf/bpftool/gen.c                              |  4 ++--
>>  tools/bpf/resolve_btfids/main.c                      |  4 ++--
>>  tools/perf/util/bpf-event.c                          |  2 +-
>>  tools/testing/selftests/bpf/btf_helpers.c            |  4 ++--
>>  tools/testing/selftests/bpf/prog_tests/btf.c         | 10 +++++-----
>>  tools/testing/selftests/bpf/prog_tests/btf_dump.c    |  8 ++++----
>>  tools/testing/selftests/bpf/prog_tests/btf_endian.c  | 12 ++++++------
>>  tools/testing/selftests/bpf/prog_tests/btf_split.c   |  2 +-
>>  .../testing/selftests/bpf/prog_tests/core_autosize.c |  2 +-
>>  tools/testing/selftests/bpf/prog_tests/core_reloc.c  |  2 +-
>>  .../selftests/bpf/prog_tests/resolve_btfids.c        |  4 ++--
>>  12 files changed, 33 insertions(+), 33 deletions(-)
>>
> 
> Please split each tool into a separate patch, and selftests separate
> from tools as well. Otherwise, great job, thanks!
> 

I was hesitant to separate these changes to individual patches.
Will do since you ask for it. Thanks.

> [...]
> 



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux