On Tue, Oct 19, 2021 at 10:44:11AM -0400, Steven Rostedt wrote: > On Tue, 19 Oct 2021 16:03:03 +0200 > Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > > You can make sure the patches in there have your latest version, as you can > > > review my patch. I'll update the tags if you give me one. > > > > I'm getting error when compiling: > > > > CC kernel/trace/ftrace.o > > kernel/trace/ftrace.c: In function ‘modify_ftrace_direct_multi’: > > kernel/trace/ftrace.c:5608:2: error: label ‘out_unlock’ defined but not used [-Werror=unused-label] > > Ah, I don't think I've been hit by the "-Werror" yet ;-) > > > > 5608 | out_unlock: > > | ^~~~~~~~~~ > > > > looks like out_unlock is nolonger needed, I removed it > > My tests would have found this, as it has a check for "new warnings". > > Anyway, was this in your latest patch, or did I pull in and older one? > > That is, should I expect a v2 from you? it's on top of your ftrace/core, in your change: e62d91d8206e ftrace/direct: Do not disable when switching direct callers just removing the label will fix it also you can add my ack Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx> thanks, jirka
