On Mon, Oct 11, 2021 at 1:54 PM Dave Marchevsky <davemarchevsky@xxxxxx> wrote:
>
> verified_insns field was added to response of bpf_obj_get_info_by_fd
> call on a prog. Confirm that it's being populated by loading a simple
> program and asking for its info.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@xxxxxx>
> ---
one nit below
Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> .../selftests/bpf/prog_tests/verif_stats.c | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/verif_stats.c
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/verif_stats.c b/tools/testing/selftests/bpf/prog_tests/verif_stats.c
> new file mode 100644
> index 000000000000..42843db519e5
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/verif_stats.c
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2021 Facebook */
> +
> +#include <test_progs.h>
> +
> +#include "trace_vprintk.lskel.h"
> +
> +void test_verif_stats(void)
> +{
> + __u32 len = sizeof(struct bpf_prog_info);
> + struct bpf_prog_info info = {};
> + struct trace_vprintk *skel;
> + int err;
> +
> + skel = trace_vprintk__open_and_load();
> + if (!ASSERT_OK_PTR(skel, "trace_vprintk__open_and_load"))
> + goto cleanup;
> +
> + if (!ASSERT_GT(skel->progs.sys_enter.prog_fd, 0, "sys_enter_fd > 0"))
> + goto cleanup;
This can't fail if open_and_load succeeded. If it does happen due to
some bug, then bpf_obj_get_info_by_fd() below will fail.
> +
> + err = bpf_obj_get_info_by_fd(skel->progs.sys_enter.prog_fd, &info, &len);
> + if (!ASSERT_OK(err, "bpf_obj_get_info_by_fd"))
> + goto cleanup;
> +
> + if (!ASSERT_GT((__u32)info.verified_insns, 0, "verified_insns"))
> + goto cleanup;
> +
> +cleanup:
> + trace_vprintk__destroy(skel);
> +}
> --
> 2.30.2
>
