Joanne Koong <joannekoong@xxxxxx> writes: > On 10/12/21 7:11 AM, Toke Høiland-Jørgensen wrote: > >> Martin KaFai Lau <kafai@xxxxxx> writes: >>> On Sat, Oct 09, 2021 at 12:20:27AM +0200, Toke Høiland-Jørgensen wrote: >>> [...] >>> I don't mind to go with the for_each helper. However, with another >>> thought, if it needs to call a function in the loop anyway, I think >>> it could also be done in bpf by putting a global function in a loop. >>> Need to try and double check. >> Hmm, that would be interesting if possible! >> >> -Toke >> > Martin and I tried this out. When we moved out the logic for parsing the > options into a global non-inlined function, the verifier approved the > program. Excellent! > As such, I will abandon this patchset and submit a new separate patch > that will add a test to ensure we're always able to parse header options > through a global function. > > Thanks for the conversation on this, Toke, Martin, and Daniel! Sounds good - you're welcome :) -Toke
