On Fri, Oct 8, 2021 at 3:55 PM sunyucong@xxxxxxxxx <sunyucong@xxxxxxxxx> wrote: > > On Fri, Oct 8, 2021 at 3:27 PM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > On Wed, Oct 6, 2021 at 11:56 AM Yucong Sun <fallentree@xxxxxx> wrote: > > > > > > From: Yucong Sun <sunyucong@xxxxxxxxx> > > > > > > Change tests that often fails in parallel execution mode to serial. > > > > > > Signed-off-by: Yucong Sun <sunyucong@xxxxxxxxx> > > > --- > > > > I hope we'll be able to parallelise these tests over time. See some > > notes on cover letter for how to target this effort better. But here's > > another thought I had while thinking about this. > > > > Some tests are inherently testing unshareable resources, e.g., like > > XDP tests. So we might never be able to completely parallelize all the > > tests. But it probably will be too restrictive to just bunde all of > > them into the one "serial" group of tests. It's a good starting point, > > but I think we'll have to have something like "serialization" group, > > where we'll be able to mark a bunch of tests like > > "serial_xdp_<testname>" and each test with "serial_xdp_" prefix will > > run sequentially relative to each other, but they might run completely > > parallel to, say, "serial_perf_" tests. WDYT? > > I think someone was talking about being able to attach multiple XDP > programs in the future? > that's all built on top of single XDP attach point using a bunch of conventions, so that's not a solution here > another approach I want to suggest is for each test to test for > EBUSY/EEXIST error code on attach and simply sleep/retry, Then in the > future when it doesn't return this error there is nothing to change on > test side. This won't work reliably, sometimes test just makes some system-wide assumptions or modifications, it's not always resulting in EBUSY > > > > > > > tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/bpf_obj_id.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/cg_storage_multi.c | 2 +- > > > .../selftests/bpf/prog_tests/cgroup_attach_autodetach.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/cgroup_attach_multi.c | 2 +- > > > .../testing/selftests/bpf/prog_tests/cgroup_attach_override.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/cgroup_link.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/check_mtu.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 3 ++- > > > .../selftests/bpf/prog_tests/flow_dissector_load_bytes.c | 2 +- > > > .../testing/selftests/bpf/prog_tests/flow_dissector_reattach.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/kfree_skb.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/modify_return.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/ns_current_pid_tgid.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/perf_buffer.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/perf_link.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/probe_user.c | 3 ++- > > > .../selftests/bpf/prog_tests/raw_tp_writable_test_run.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 2 +- > > > .../selftests/bpf/prog_tests/send_signal_sched_switch.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/sk_storage_tracing.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/snprintf_btf.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/sock_fields.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/sockmap_listen.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/timer.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/timer_mim.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/tp_attach_query.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/trace_printk.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/trace_vprintk.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/trampoline_count.c | 3 ++- > > > tools/testing/selftests/bpf/prog_tests/xdp_attach.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/xdp_bonding.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/xdp_cpumap_attach.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/xdp_devmap_attach.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/xdp_info.c | 2 +- > > > tools/testing/selftests/bpf/prog_tests/xdp_link.c | 2 +- > > > 38 files changed, 48 insertions(+), 38 deletions(-) > > > > > > diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c b/tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c > > > index 85babb0487b3..b52ff8ce34db 100644 > > > --- a/tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c > > > +++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c > > > @@ -179,7 +179,7 @@ static void do_bpf_iter_setsockopt(struct bpf_iter_setsockopt *iter_skel, > > > free_fds(est_fds, nr_est); > > > } > > > > > > > [...]
