Re: [PATCH bpf-next 1/2] bpf: Add bpf_skc_to_unix_sock() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/6/21 1:00 PM, Song Liu wrote:
> On Tue, Oct 5, 2021 at 9:08 PM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote:
>>
>> The helper is used in tracing programs to cast a socket
>> pointer to a unix_sock pointer.
>> The return value could be NULL if the casting is illegal.
>>
>> Suggested-by: Yonghong Song <yhs@xxxxxx>
>> Signed-off-by: Hengqi Chen <hengqi.chen@xxxxxxxxx>
> 
> Acked-by: Song Liu <songliubraving@xxxxxx>
> 
> With one nitpick below.
> 
> [...]
>> --- a/scripts/bpf_doc.py
>> +++ b/scripts/bpf_doc.py
>> @@ -250,17 +250,17 @@ class PrinterRST(Printer):
>>          license = '''\
>>  .. Copyright (C) All BPF authors and contributors from 2014 to present.
>>  .. See git log include/uapi/linux/bpf.h in kernel tree for details.
>> -..
>> +..
> 
> nit: We usually exclude these trailing space changes from the patch.
> 

Thanks for the review, will drop these unrelated changes in v2.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux