On Tue, Oct 5, 2021 at 3:22 PM Song Liu <song@xxxxxxxxxx> wrote: > > On Sun, Oct 3, 2021 at 10:00 AM Hengqi Chen <hengqi.chen@xxxxxxxxx> wrote: > > > > Deprecate bpf_{map,program}__{prev,next} APIs. Replace them with > > a new set of APIs named bpf_object__{prev,next}_{program,map} which > > follow the libbpf API naming convention.[0] No functionality changes. > > > > Closes: https://github.com/libbpf/libbpf/issues/296 > ^^^ I guess we need "[0]" here? > > > > > Signed-off-by: Hengqi Chen <hengqi.chen@xxxxxxxxx> > > --- > > Other than the nitpick above Fixed that up while applying. There were also 4 more uses of bpf_program__next and bpf_map__next in bpftool and samples/bpf, I've fixed them up as well to not come back to this again. Hengqi, for future deprecations, please do grep for the entire Linux source code, not just selftests, there are a bunch of other tools and parts of the kernel that use libbpf APIs. Applied to bpf-next, thanks. > > Acked-by: Song Liu <songliubraving@xxxxxx>