On Tue, Oct 5, 2021 at 5:29 PM Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> wrote:
>
> The allocated ring buffer is never freed, do so in the cleanup path.
>
> Fixes: f446b570ac7e (bpf/selftests: Update the IMA test to use BPF ring buffer)
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx>
> ---
Please stick to "selftests/bpf: " prefix which we use consistently for
BPF selftests patches.
Other than that LGTM.
Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> tools/testing/selftests/bpf/prog_tests/test_ima.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/test_ima.c b/tools/testing/selftests/bpf/prog_tests/test_ima.c
> index 0252f61d611a..97d8a6f84f4a 100644
> --- a/tools/testing/selftests/bpf/prog_tests/test_ima.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_ima.c
> @@ -43,7 +43,7 @@ static int process_sample(void *ctx, void *data, size_t len)
> void test_test_ima(void)
> {
> char measured_dir_template[] = "/tmp/ima_measuredXXXXXX";
> - struct ring_buffer *ringbuf;
> + struct ring_buffer *ringbuf = NULL;
> const char *measured_dir;
> char cmd[256];
>
> @@ -85,5 +85,6 @@ void test_test_ima(void)
> err = system(cmd);
> CHECK(err, "failed to run command", "%s, errno = %d\n", cmd, errno);
> close_prog:
> + ring_buffer__free(ringbuf);
> ima__destroy(skel);
> }
> --
> 2.33.0
>
