On Sat, 2 Oct 2021 at 00:20, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Fri, Oct 1, 2021 at 4:09 AM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote: > > > > API headers from libbpf should not be accessed directly from the > > library's source directory. Instead, they should be exported with "make > > install_headers". Let's make sure that bpf/preload/iterators/Makefile > > installs the headers properly when building. > > > > -$(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) | $(OUTPUT) > > +$(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) \ > > + | $(LIBBPF_OUTPUT) $(LIBBPF_INCLUDE) > > Would it make sense for libbpf's Makefile to create include and output > directories on its own? We wouldn't need to have these order-only > dependencies everywhere, right? Good point, I'll have a look at it. Quentin
