> -----Original Message----- > From: Cong Wang [mailto:xiyou.wangcong@xxxxxxxxx] > Sent: Tuesday, September 28, 2021 1:52 PM > To: liujian (CE) <liujian56@xxxxxxxxxx> > Cc: John Fastabend <john.fastabend@xxxxxxxxx>; Daniel Borkmann > <daniel@xxxxxxxxxxxxx>; Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>; Lorenz > Bauer <lmb@xxxxxxxxxxxxxx>; David Miller <davem@xxxxxxxxxxxxx>; Jakub > Kicinski <kuba@xxxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Andrii > Nakryiko <andrii@xxxxxxxxxx>; Martin KaFai Lau <kafai@xxxxxx>; Song Liu > <songliubraving@xxxxxx>; Yonghong Song <yhs@xxxxxx>; KP Singh > <kpsingh@xxxxxxxxxx>; Linux Kernel Network Developers > <netdev@xxxxxxxxxxxxxxx>; bpf <bpf@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v3] skmsg: lose offset info in sk_psock_skb_ingress > > On Wed, Sep 22, 2021 at 2:32 AM Liu Jian <liujian56@xxxxxxxxxx> wrote: > > static void sk_psock_skb_state(struct sk_psock *psock, @@ -604,6 > > +608,9 @@ static void sk_psock_backlog(struct work_struct *work) { > > struct sk_psock *psock = container_of(work, struct sk_psock, work); > > struct sk_psock_work_state *state = &psock->work_state; > > +#if IS_ENABLED(CONFIG_BPF_STREAM_PARSER) > > + struct strp_msg *stm = NULL; > > +#endif > > struct sk_buff *skb = NULL; > > bool ingress; > > u32 len, off; > > @@ -624,6 +631,13 @@ static void sk_psock_backlog(struct work_struct > *work) > > while ((skb = skb_dequeue(&psock->ingress_skb))) { > > len = skb->len; > > off = 0; > > +#if IS_ENABLED(CONFIG_BPF_STREAM_PARSER) > > + if (skb_bpf_strparser(skb)) { > > If CONFIG_BPF_STREAM_PARSER is disabled, this should always return false, > hence you don't need this #ifdef. > Or alternatively, you can at least define for nop for > skb_bpf_strparser() if !CONFIG_BPF_STREAM_PARSER. > And you can move the above "stm" down here too. > V4 has been sent, thank you~ > (Ditto for the other place below.) > > Thanks.
