Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Thu, 9 Sep 2021 10:05:29 +0200
Cc: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Luigi Rizzo <lrizzo@xxxxxxxxxx>, Yonghong Song <yhs@xxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, "kernel-team@xxxxxx" <kernel-team@xxxxxx>, "walken@xxxxxx" <walken@xxxxxx>
In-reply-to: <20210908183032.zoh6dj5xh455z47f@revolver>

On Wed, Sep 08, 2021 at 06:30:52PM +0000, Liam Howlett wrote:
> +	VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm);

NAK.. do not ever use the _is_locked() trainwrecks.

References:
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Luigi Rizzo
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Liam Howlett
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Yonghong Song
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Luigi Rizzo
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Alexei Starovoitov
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Andrew Morton
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Alexei Starovoitov
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Andrew Morton
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Alexei Starovoitov
- Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
  - From: Liam Howlett

Prev by Date: Re: [PATCH bpf-next] bpf: Change value of MAX_TAIL_CALL_CNT from 32 to 33
Next by Date: Re: [PATCH -next] bpf: Add oversize check before call kvcalloc()
Previous by thread: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
Next by thread: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]