Re: [PATCH bpf-next] bpf,x64 Emit IMUL instead of MUL for x86-64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 8, 2021 at 5:14 PM Jie Meng <jmeng@xxxxxx> wrote:
>
> IMUL allows for multiple operands and saving and storing rax/rdx is no
> longer needed. Signedness of the operands doesn't matter here because
> the we only keep the lower 32/64 bit of the product for 32/64 bit
> multiplications.
>
> Signed-off-by: Jie Meng <jmeng@xxxxxx>
> ---

This change breaks selftests ([0]), please fix.

  [0] https://github.com/kernel-patches/bpf/pull/1746/checks?check_run_id=3550847581

>  arch/x86/net/bpf_jit_comp.c                | 53 ++++++++++------------
>  tools/testing/selftests/bpf/verifier/jit.c | 16 +++++++
>  2 files changed, 39 insertions(+), 30 deletions(-)
>

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux