On Wed, Sep 01, 2021 at 07:12:24PM +0200, Peter Zijlstra wrote: > On Mon, Aug 30, 2021 at 08:07:24PM +0200, Peter Zijlstra wrote: > > On Mon, Aug 30, 2021 at 05:41:46PM +0000, Song Liu wrote: > > > DECLARE_STATIC_CALL(perf_snapshot_branch_stack, > > > int (*)(struct perf_branch_snapshot *)); > > > > > Something like > > > > > > typedef int (perf_snapshot_branch_stack_t)(struct perf_branch_snapshot *); > > > DECLARE_STATIC_CALL(perf_snapshot_branch_stack, perf_snapshot_branch_stack_t); > > > > > > seems to work fine. > > > > Oh urg, indeed. It wants a function type, not a function pointer type. > > I've been bitten by that before. Go with the typedef, that's the sanest. > > The below is the best I can make of it... it's a little inconsistent and > somewhat tricky, but at least the compiler yells hard if you get it > wrong. > > I can *almost* get to: DEFINE_STATIC_CALL(foo, &func), except for > ARCH_DEFINE_STATIC_CALL_TRAMP() which needs the actual function name > string for the ASM :-( > > The rest can do with a function pointer type and have it work. Seems reasonable to me. -- Josh
