Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.

Yonghong Song <yhs@xxxxxx> · Tue, 10 Aug 2021 16:46:49 -0700

On 8/10/21 2:28 AM, Kuniyuki Iwashima wrote:
The iterator can output the same result compared to /proc/net/unix.

   # cat /sys/fs/bpf/unix
   Num       RefCount Protocol Flags    Type St Inode Path
   ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer

There seems a misalignment between header line and data line.
I know /proc/net/unix having this issue as well. But can we adjust 
spacing in bpf program to make header/data properly aligned?

   ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@

   # cat /proc/net/unix
   Num       RefCount Protocol Flags    Type St Inode Path
   ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
   ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@

Note that this prog requires the patch ([0]) for LLVM code gen.  Thanks to
Yonghong Song for analysing and fixing.

[0] https://reviews.llvm.org/D107483

Signed-off-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxxxx>

LGTM. Thanks!

Acked-by: Yonghong Song <yhs@xxxxxx>