On 8/10/21 6:25 PM, Andrii Nakryiko wrote:
On Tue, Aug 10, 2021 at 4:23 AM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
On 8/10/21 2:16 AM, Yucong Sun wrote:
This patch records all failed tests and subtests during the run, output
them after the summary line, making it easier to identify failed tests
in the long output.
Signed-off-by: Yucong Sun <fallentree@xxxxxx>
nit: please prefix all $subjects with e.g. 'bpf, selftests:'. for example, here should
be 'bpf, selftests: Record all failed tests and output after the summary line' so it's
more clear in the git log which subsystem is meant.
Thank, Daniel, for catching this!
We've more or less consistently used these prefixes (with the emphasis
on "more or less", of course):
1. 'bpf:', for BPF-related kernel proper patches
2. 'libbpf:', for libbpf patches
3. 'selftests/bpf:'. for BPF selftests
4. 'bpftool:', for bpftool-specific patches
5. 'samples/bpf', for, you guessed it, samples/bpf :)
I don't know how much value it is to record this convention in our
docs Q&A doc, but it's worth keeping this convention consistent.
Agree, it somewhat evolved into these 5 main areas above. Might be worth putting
a note into q&a doc or at least tweak $subject line while applying if it's too
far off. :)
Haven't checked the logic of this patch yet, but thought I'll comment
on this convention (and a minor styling nit below).
