On Mon, Aug 9, 2021 at 5:17 PM Yucong Sun <fallentree@xxxxxx> wrote: > > In skip_account(), test->skip_cnt is set to 0 at the end, this makes > next print statement never display SKIP status for the subtest. This > patch moves the accounting logic after the print statement, fixing the > issue. > > Signed-off-by: Yucong Sun <fallentree@xxxxxx> > --- Looks good, but seems like we are not printing SKIP for normal tests, let's do that while we are at fixing SKIP reporting? > tools/testing/selftests/bpf/test_progs.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c > index c5bffd2e78ae..82d012671552 100644 > --- a/tools/testing/selftests/bpf/test_progs.c > +++ b/tools/testing/selftests/bpf/test_progs.c > @@ -238,18 +238,18 @@ void test__end_subtest() > struct prog_test_def *test = env.test; > int sub_error_cnt = test->error_cnt - test->old_error_cnt; > > - if (sub_error_cnt) > - env.fail_cnt++; > - else if (test->skip_cnt == 0) > - env.sub_succ_cnt++; > - skip_account(); > - > dump_test_log(test, sub_error_cnt); > > fprintf(env.stdout, "#%d/%d %s:%s\n", > test->test_num, test->subtest_num, test->subtest_name, > sub_error_cnt ? "FAIL" : (test->skip_cnt ? "SKIP" : "OK")); > > + if (sub_error_cnt) > + env.fail_cnt++; > + else if (test->skip_cnt == 0) > + env.sub_succ_cnt++; > + skip_account(); > + > free(test->subtest_name); > test->subtest_name = NULL; > } > -- > 2.30.2 >
