From: Martin KaFai Lau <kafai@xxxxxx>
Date: Thu, 5 Aug 2021 17:41:14 -0700
> On Wed, Aug 04, 2021 at 04:08:50PM +0900, Kuniyuki Iwashima wrote:
> > Currently, the batch optimization introduced for the TCP iterator in the
> > commit 04c7820b776f ("bpf: tcp: Bpf iter batching and lock_sock") is not
> > applied. It will require replacing the big lock for the hash table with
> may be s/applied/used/. I thought it meant the commit is not landed.
Ah sorry, I meant the same optimisation logic is not used for now.
I'll change the word.
> > small locks for each hash list not to block other processes.
> Right, I don't think it can be directly reused. Not necessary
> related to the big lock though. Actually, a big lock will still
> work for batching but just less ideal.
Yes, batching can be done with a big lock.
> Batching is needed for supporting bpf_setsockopt. It can be added later
> together with the bpf_setsockopt support.
I'm trying to replace the big lock, so I'll submit another set for batching
and bpf_setsockopt support.
Thank you!
