Re: [PATCH bpf v2 3/3] bpf, sockmap: fix memleak on ingress msg enqueue

[John Fastabend <john.fastabend@xxxxxxxxx>]

Martin KaFai Lau wrote:
> On Mon, Jul 26, 2021 at 09:53:04AM -0700, John Fastabend wrote:
> > --- a/include/linux/skmsg.h
> > +++ b/include/linux/skmsg.h
> > @@ -285,11 +285,45 @@ static inline struct sk_psock *sk_psock(const struct sock *sk)
> >  	return rcu_dereference_sk_user_data(sk);
> >  }
> >  
> > +static inline void sk_psock_set_state(struct sk_psock *psock,
> > +				      enum sk_psock_state_bits bit)
> > +{
> > +	set_bit(bit, &psock->state);
> > +}
> > +
> > +static inline void sk_psock_clear_state(struct sk_psock *psock,
> > +					enum sk_psock_state_bits bit)
> > +{
> > +	clear_bit(bit, &psock->state);
> > +}
> > +
> > +static inline bool sk_psock_test_state(const struct sk_psock *psock,
> > +				       enum sk_psock_state_bits bit)
> > +{
> > +	return test_bit(bit, &psock->state);
> > +}
> > +
> > +static void sock_drop(struct sock *sk, struct sk_buff *skb)
> inline


Thanks will fix, bit surprised I didn't get a build warning for the typo.