On Thu, Apr 29, 2021 at 8:32 AM Jussi Maki <joamaki@xxxxxxxxx> wrote:
>
> Ports test_tc_redirect.sh to the test_progs framework and removes the
> old test. This makes it more in line with rest of the tests and makes
> it possible to run this test with vmtest.sh and under the bpf CI.
>
> Signed-off-by: Jussi Maki <joamaki@xxxxxxxxx>
> ---
Hey Jussi,
I noticed that running these new tc_redirect tests locally in my qemu
image were failing. I narrowed it down to `ping6` vs `ping -6`
differences. My image lacks ping6. I see that there were previous
attempts to gracefully handle them both:
da85d8bfd151 ("kselftests/bpf: use ping6 as the default ipv6 ping
binary when it exists")
deee2cae27d1 ("kselftests/bpf: use ping6 as the default ipv6 ping
binary if it exists")
(those are two different commits, yeah :) )
It seems the shell script version used to handle this more gracefully.
Can you please update the test to handle the lack of ping6 binary?
> tools/testing/selftests/bpf/network_helpers.c | 2 +-
> tools/testing/selftests/bpf/network_helpers.h | 1 +
> .../selftests/bpf/prog_tests/tc_redirect.c | 481 ++++++++++++++++++
> .../selftests/bpf/progs/test_tc_neigh.c | 33 +-
> .../selftests/bpf/progs/test_tc_neigh_fib.c | 9 +-
> .../selftests/bpf/progs/test_tc_peer.c | 33 +-
> .../testing/selftests/bpf/test_tc_redirect.sh | 216 --------
> 7 files changed, 509 insertions(+), 266 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/tc_redirect.c
> delete mode 100755 tools/testing/selftests/bpf/test_tc_redirect.sh
>
[...]
