On Fri, Jul 16, 2021 at 3:47 PM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote: > > Fix issues with libbpf BTF typed dump code. Patch 1 addresses handling > of unaligned data. Patch 2 fixes issues Andrii noticed when compiling > on ppc64le. Patch 3 simplifies typed dump by getting rid of allocation > of dump data structure which tracks dump state etc. > > Changes since v1: > > - Andrii suggested using a function instead of a macro for checking > alignment of data, and pointed out that we need to consider dump > ptr size versus native pointer size (patch 1) > > Alan Maguire (3): > libbpf: clarify/fix unaligned data issues for btf typed dump > libbpf: fix compilation errors on ppc64le for btf dump typed data > libbpf: btf typed dump does not need to allocate dump data > > tools/lib/bpf/btf_dump.c | 39 ++++++++++++++++++++++++++++++--------- > 1 file changed, 30 insertions(+), 9 deletions(-) > > -- > 1.8.3.1 > Thank you for the quick follow up. But see all the comments I left and the fix ups I had to do. Just because the changes are small doesn't mean you should get sloppy about making them. Please be a bit more thorough in future patches. Applied to bpf-next.
